samarthjain commented on pull request #4454:
URL: https://github.com/apache/iceberg/pull/4454#issuecomment-1085034853
> I think it is okay. initialize is called just after creating the FileIO
instance before it is shared across threads.
At a minimum, I think this should be documented in the FileIO interface.
> Yes, we do assume that these are shared.
It would make sense to document within the interface that this is indeed
the case so future maintainers / implementations can guard appropriately
against multi-threaded access.
> It may be simpler just to eagerly create the S3 client.
+1 to this. We really shouldn't be doing lazy inits unless creating the
object is expensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
