aokolnychyi commented on a change in pull request #4469:
URL: https://github.com/apache/iceberg/pull/4469#discussion_r840970832
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteOrphanFilesSparkAction.java
##########
@@ -87,22 +87,20 @@
}
}, DataTypes.StringType);
- private static final ExecutorService DEFAULT_DELETE_EXECUTOR_SERVICE = null;
-
private final SerializableConfiguration hadoopConf;
private final int partitionDiscoveryParallelism;
private final Table table;
-
- private String location = null;
- private long olderThanTimestamp = System.currentTimeMillis() -
TimeUnit.DAYS.toMillis(3);
- private Consumer<String> deleteFunc = new Consumer<String>() {
+ private final Consumer<String> defaultDelete = new Consumer<String>() {
Review comment:
In most other places, we have a separate `defaultDelete` var.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
