aokolnychyi commented on a change in pull request #4469:
URL: https://github.com/apache/iceberg/pull/4469#discussion_r840972373
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteReachableFilesSparkAction.java
##########
@@ -103,53 +87,46 @@ public DeleteReachableFiles io(FileIO fileIO) {
@Override
public DeleteReachableFiles deleteWith(Consumer<String> deleteFunc) {
- this.removeFunc = deleteFunc;
+ this.deleteFunc = deleteFunc;
return this;
-
}
@Override
public DeleteReachableFiles executeDeleteWith(ExecutorService
executorService) {
- this.removeExecutorService = executorService;
+ this.deleteExecutorService = executorService;
return this;
}
@Override
public Result execute() {
- Preconditions.checkArgument(io != null, "File IO cannot be null");
Review comment:
I don't think we need this check any more as the `FileIO` is defaulted
all the time. This may be null only if the user explicitly sets it. Since we
don't validate such cases in other places, it seemed fine to skip this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
