shidayang commented on a change in pull request #4459:
URL: https://github.com/apache/iceberg/pull/4459#discussion_r841031140



##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopTables.java
##########
@@ -68,12 +69,23 @@
 
   private Configuration conf;
 
+  private FileIO fileIO;
+
   public HadoopTables() {
     this(new Configuration());
   }
 
+  public HadoopTables(FileIO fileIO) {

Review comment:
       Thanks for your review, My FileSystem which has some external function 
such as authentication is not a standard implementation. In other cases, Many 
Engines has owner FileSystem Manager so they don't need HadoopTables to 
initialize FileSystem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to