shidayang commented on a change in pull request #4459:
URL: https://github.com/apache/iceberg/pull/4459#discussion_r841043637
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopTables.java
##########
@@ -68,12 +69,23 @@
private Configuration conf;
+ private FileIO fileIO;
+
public HadoopTables() {
this(new Configuration());
}
+ public HadoopTables(FileIO fileIO) {
Review comment:
In the one hand, The only difference is the FileIO. The constructor of
HadoopTableOperations is protected and constructor args has FileIO, So the
design philosophy of HadoopTableOperations is support Dynamic FileIO.
In other hand, like apache/iceberg#1618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
