rajarshisarkar commented on code in PR #4402:
URL: https://github.com/apache/iceberg/pull/4402#discussion_r841635421
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -388,6 +429,8 @@ public AwsProperties(Map<String, String> properties) {
this.glueLakeFormationEnabled = PropertyUtil.propertyAsBoolean(properties,
GLUE_LAKEFORMATION_ENABLED,
GLUE_LAKEFORMATION_ENABLED_DEFAULT);
+ this.tableName = properties.get(LAKE_FORMATION_TABLE_NAME);
Review Comment:
Few doubts:
1. For table level S3 tags, do we need to create new FileIOs for each
`newTableOps` call (when LF is not enabled)? The current condition is:
```
protected TableOperations newTableOps(TableIdentifier tableIdentifier) {
if (catalogProperties != null) {
...
}
```
2. The `tableIdentifier` doesn't have table UUID right now. Should I add the
same in the table identifier object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
