rajarshisarkar commented on code in PR #4402:
URL: https://github.com/apache/iceberg/pull/4402#discussion_r858666777
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -110,13 +110,15 @@ public GlueCatalog() {
@Override
public void initialize(String name, Map<String, String> properties) {
AwsClientFactory awsClientFactory;
+ ImmutableMap.Builder<String, String> builder = ImmutableMap.<String,
String>builder().putAll(properties);
Review Comment:
[Doubt] If the user passes only the table level tag properties, then we will
build the map and according to this logic we would skip the else block. Thereby
not initialising `awsClientFactory` and `catalogFileIO` which should not be the
intended behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
