szehon-ho commented on code in PR #4382:
URL: https://github.com/apache/iceberg/pull/4382#discussion_r842136719
##########
core/src/main/java/org/apache/iceberg/BaseMetadataTableScan.java:
##########
@@ -31,11 +37,30 @@ protected BaseMetadataTableScan(TableOperations ops, Table
table, Schema schema,
super(ops, table, schema, context);
}
+ /**
+ * @return if metadata table scan is for all snapshots, ie 'all_x' metadata
tables
+ */
+ protected boolean allScan() {
Review Comment:
@aokolnychyi yea i had that version in the previous iteration, having a
method like:
```
BaseMetadataTableScan.scanAllManifests(); //like planFiles but across all
manifests.
```
and then having:
```
@Override
BaseAllMetadataTableScan.planFiles() {
super.scanAllManifests();
}
@Override
AllDataFileTableScan.planFiles() {
super.scanAllManifests();
}
```
Is that better than this? I can revert back to that version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
