szehon-ho commented on code in PR #4382:
URL: https://github.com/apache/iceberg/pull/4382#discussion_r842173685
##########
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##########
@@ -108,23 +108,21 @@ public TableScan appendsAfter(long fromSnapshotId) {
}
/**
- * @return list of manifest files to explore for this files metadata table
scan
+ * @return iterable of manifest files to explore for this files metadata
table scan
*/
- protected abstract List<ManifestFile> manifests();
+ protected abstract CloseableIterable<ManifestFile> manifests();
- private CloseableIterable<ManifestFile> filterManifests(List<ManifestFile>
manifests,
+ private CloseableIterable<ManifestFile>
filterManifests(CloseableIterable<ManifestFile> manifests,
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
