rdblue commented on code in PR #4464:
URL: https://github.com/apache/iceberg/pull/4464#discussion_r843039614
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -441,9 +440,8 @@ private void applyUpdates(TableOperations underlyingOps) {
try {
update.commit();
} catch (CommitFailedException e) {
- // fallback to old base, so that it refreshes again on retry and
apply pending updates.
- base = oldBase;
- throw e;
+ // Cannot pass even with retry. So, break the retry-loop.
+ throw new RuntimeException("Failed to apply pending updates", e);
Review Comment:
This should not be a RuntimeException. Instead, create a wrapper class that
you catch and then throw the original cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
