rdblue commented on code in PR #4464:
URL: https://github.com/apache/iceberg/pull/4464#discussion_r843167256
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -404,6 +397,9 @@ private void commitSimpleTransaction() {
.onFailure((file, exc) -> LOG.warn("Failed to delete uncommitted
file: {}", file, exc))
.run(ops.io()::deleteFile);
+ if (e instanceof ValidationFailureException) {
Review Comment:
Looks like this is here because you want to share the cleanup code, but I
think it would be cleaner to move that to a method that gets called from
separate `catch` blocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
