RussellSpitzer commented on code in PR #4377:
URL: https://github.com/apache/iceberg/pull/4377#discussion_r844000895
##########
core/src/main/java/org/apache/iceberg/actions/RewriteFileGroup.java:
##########
@@ -77,4 +77,12 @@ public String toString() {
.add("numAddedFiles", addedFiles == null ? "Rewrite Incomplete" :
Integer.toString(addedFiles.size()))
.toString();
}
+
+ public long size() {
Review Comment:
"size" in java tradition is a bit of an overloaded term it definitely
invokes number of elements. I think this should probably be sizeInBytes
and files below should probably be numFiles to differentiate from actual
fileScanTask objects or other things like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
