RussellSpitzer commented on code in PR #4377: URL: https://github.com/apache/iceberg/pull/4377#discussion_r847672641
########## api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java: ########## @@ -88,6 +89,20 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri String USE_STARTING_SEQUENCE_NUMBER = "use-starting-sequence-number"; boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = true; + /** + * Forces the rewrite job order based on the value. + * <p> + * If rewrite.job-order=bytes-asc, then rewrite the smallest job groups first. + * If rewrite.job-order=bytes-desc, then rewrite the largest job groups first. + * If rewrite.job-order=files-asc, then rewrite the job groups with the least files first. + * If rewrite.job-order=files-desc, then rewrite the job groups with the most files first. + * If rewrite.job-order=none, then rewrite job groups in the order they were planned (no specific ordering). + * <p> + * Defaults to none. + */ + String REWRITE_JOB_ORDER = "rewrite.job-order"; + String REWRITE_JOB_ORDER_DEFAULT = RewriteJobOrder.NONE.orderName(); Review Comment: nit: Default value can be of the enum type instead of string -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
