vanliu-tx commented on PR #4514: URL: https://github.com/apache/iceberg/pull/4514#issuecomment-1091054373
> Thank you for this contribution @vanliu-tx! This is a great find. > > The test is quite extensive. I left a few nits, but mostly I'm wondering if there's any kind of simpler way to test for this, like checking the sequence number of planned files after applying a delete. > > It might not be something that can be made much simpler though without refactoring the code more. > > cc @rdblue @RussellSpitzer @szehon-ho @jackye1995 you'll likely be interested in this. added some verification for manifest sequence number and min sequence number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
