rdblue commented on code in PR #4514:
URL: https://github.com/apache/iceberg/pull/4514#discussion_r847488536
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -690,7 +690,7 @@ public List<ManifestFile> apply(TableMetadata base) {
base.schema(), current != null ? current.dataManifests() : null);
long minDataSequenceNumber = filtered.stream()
.map(ManifestFile::minSequenceNumber)
- .filter(seq -> seq > 0) // filter out unassigned sequence numbers in
rewritten manifests
+ .filter(seq -> seq >= 0) // filter out unassigned sequence numbers in
rewritten manifests
Review Comment:
@vanliu-tx, I don't see how this would matter. Sequence number 0 is reserved
for v1 files, so when you convert to v2 all of the v1 files have sequence
number 0. And in v1, there are no delete files. So reporting a min sequence
number of 1 and removing all delete files older than 1 should have no change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
