aokolnychyi commented on code in PR #4520:
URL: https://github.com/apache/iceberg/pull/4520#discussion_r845573034
##########
core/src/test/java/org/apache/iceberg/TestMetadataTableFilters.java:
##########
@@ -252,6 +254,74 @@ public void testPlanTasks() {
validateCombinedScanTasks(tasks, 0);
}
+ @Test
+ public void testPartitionSpecEvolution() {
+ Assume.assumeTrue(formatVersion == 2);
Review Comment:
I'd probably prefer not to reuse `populateTableNewSpec` and duplicate some
parts of the code but cover v1 and v2 tables to be safe. Using extra helper
methods in tests reduces code duplication but makes it hard to review such
tests as I had to jump to those methods to understand the current table state.
I'd also add tests where conditions refer to fields in the old partition
spec. The `partition` column is a union of all partition types ever present in
the table. We should push down conditions on `data_bucket` to manifests that
belong to the old spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
