rdblue commented on code in PR #4495:
URL: https://github.com/apache/iceberg/pull/4495#discussion_r847503101
##########
core/src/test/java/org/apache/iceberg/rest/RESTCatalogAdapter.java:
##########
@@ -154,8 +154,7 @@ public <T extends RESTResponse> T handleRequest(Route
route, Map<String, String>
Object body, Class<T>
responseType) {
switch (route) {
case CONFIG:
- // TODO: use the correct response object
- return castResponse(responseType, ImmutableMap.of());
+ return castResponse(responseType, CatalogHandlers.fetchServerConfig());
Review Comment:
I commented above that it probably isn't very helpful to include
`fetchServerConfig()` in `CatalogHandlers`. I would recommend creating the
response directly here. You could also include a default config map for testing
purposes if you wanted, although I think you're testing it different way so you
may not need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
