kbendick commented on code in PR #4495:
URL: https://github.com/apache/iceberg/pull/4495#discussion_r845418984


##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -405,4 +435,23 @@ private String fullTableName(TableIdentifier ident) {
 
     return Pair.of(tableClient, tableIO);
   }
+
+  private Map<String, String> fetchAndMergeWithServerConf(Map<String, String> 
props) {

Review Comment:
   Yeah I had already moved it to the `try` block, but I will move the merging 
out so that this function has more of a single purpose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to