liuml07 commented on code in PR #4540:
URL: https://github.com/apache/iceberg/pull/4540#discussion_r847830058
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -490,6 +490,11 @@ public void testSparkTableReservedProperties() throws
Exception {
Assert.assertEquals("Unexpected format", "iceberg/parquet",
table.properties().get("format"));
Assert.assertNotEquals("No current-snapshot-id found", "none",
table.properties().get("current-snapshot-id"));
Assert.assertTrue("Location isn't correct",
table.properties().get("location").endsWith(destTableName));
+
+ Assert.assertNotNull("Missing format-version",
table.properties().get("format-version"));
Review Comment:
Not asserting the value being 1 in case we move the default table
format-version to 2 (this test may simply break then)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
