kbendick commented on code in PR #4540:
URL: https://github.com/apache/iceberg/pull/4540#discussion_r847833078
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -490,6 +490,11 @@ public void testSparkTableReservedProperties() throws
Exception {
Assert.assertEquals("Unexpected format", "iceberg/parquet",
table.properties().get("format"));
Assert.assertNotEquals("No current-snapshot-id found", "none",
table.properties().get("current-snapshot-id"));
Assert.assertTrue("Location isn't correct",
table.properties().get("location").endsWith(destTableName));
+
+ Assert.assertNotNull("Missing format-version",
table.properties().get("format-version"));
Review Comment:
I think it's fine to assert the value is 1. That's the current expected
behavior (format-version is 1 for tables created by Spark).
If / when we update the default to 2, we'll update the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
