amogh-jahagirdar commented on code in PR #4071:
URL: https://github.com/apache/iceberg/pull/4071#discussion_r848987602
##########
core/src/test/java/org/apache/iceberg/TestSnapshotManager.java:
##########
@@ -250,4 +248,305 @@ public void testCherryPickOverwrite() {
lastSnapshotId, table.currentSnapshot().snapshotId());
validateTableFiles(table, FILE_A, FILE_B);
}
+
+ @Test
+ public void testCreateBranch() {
+ table.newAppend()
+ .appendFile(FILE_A)
+ .commit();
+ long snapshotId = table.currentSnapshot().snapshotId();
+ // Test a basic case of creating a branch
+ table.manageSnapshots()
+ .createBranch("branch1", snapshotId)
+ .commit();
+ SnapshotRef expectedBranch = table.ops().refresh().ref("branch1");
+ Assert.assertTrue(expectedBranch != null &&
+
expectedBranch.equals(SnapshotRef.branchBuilder(snapshotId).build()));
+
+ // Trying to create a branch with an existing name should fail
+ AssertHelpers.assertThrows("Should fail validation check if we try and
create branch again",
+ IllegalArgumentException.class, "Ref branch1 already exists",
+ () -> table.manageSnapshots().createBranch("branch1",
snapshotId).commit());
+
+ // Trying to create another branch within the same chain
+ AssertHelpers.assertThrows("Should fail validation check if we try and
create branch again",
+ IllegalArgumentException.class, "Ref branch2 already exists",
+ () -> table.manageSnapshots().createBranch("branch2",
snapshotId).createBranch("branch2", snapshotId).commit());
Review Comment:
Definitley, on the latest version I have broken up the tests more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
