amogh-jahagirdar commented on code in PR #4071: URL: https://github.com/apache/iceberg/pull/4071#discussion_r848992619
########## core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java: ########## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import java.util.Map; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.util.SnapshotUtil; + +/** + * ToDo: Add SetSnapshotOperation operations such as setCurrentSnapshot, rollBackTime, rollbackTo + * to this class so that we can support those operations for refs. + */ +class UpdateSnapshotReferencesOperation implements PendingUpdate<Map<String, SnapshotRef>> { + + private final TableOperations ops; + private final Map<String, SnapshotRef> updatedRefs; + private TableMetadata base; + + UpdateSnapshotReferencesOperation(TableOperations ops) { + this.ops = ops; + this.base = ops.current(); + this.updatedRefs = Maps.newHashMap(base.refs()); + } + + @Override + public Map<String, SnapshotRef> apply() { + return updatedRefs; + } + + @Override + public void commit() { + TableMetadata updated = internalApply(); + ops.commit(base, updated); + } + + public UpdateSnapshotReferencesOperation createBranch(String name, long snapshotId) { + Preconditions.checkNotNull(name, "Branch name cannot be null"); + SnapshotRef branch = SnapshotRef.branchBuilder(snapshotId).build(); + SnapshotRef existingRef = updatedRefs.put(name, branch); + Preconditions.checkArgument(existingRef == null, "Ref %s already exists", name); + return this; + } + + public UpdateSnapshotReferencesOperation createTag(String name, long snapshotId) { + Preconditions.checkNotNull(name, "Tag name cannot be null"); + SnapshotRef tag = SnapshotRef.tagBuilder(snapshotId).build(); + SnapshotRef existingRef = updatedRefs.put(name, tag); + Preconditions.checkArgument(existingRef == null, "Ref %s already exists", name); + return this; + } + + public UpdateSnapshotReferencesOperation removeBranch(String name) { + Preconditions.checkNotNull(name, "Branch name cannot be null"); + Preconditions.checkArgument(!name.equals(SnapshotRef.MAIN_BRANCH), "Cannot remove main branch"); + SnapshotRef ref = updatedRefs.remove(name); + Preconditions.checkArgument(ref != null, "Branch does not exist: %s", name); + Preconditions.checkArgument(ref.isBranch(), "Ref %s is a tag not a branch", name); + return this; + } + + public UpdateSnapshotReferencesOperation removeTag(String name) { + Preconditions.checkNotNull(name, "Tag name cannot be null"); + SnapshotRef ref = updatedRefs.remove(name); + Preconditions.checkArgument(ref != null, "Tag does not exist: %s", name); + Preconditions.checkArgument(ref.isTag(), "Ref %s is a branch not a tag", name); + return this; + } + + public UpdateSnapshotReferencesOperation renameBranch(String name, String newName) { + Preconditions.checkNotNull(name, "Branch to rename cannot be null"); + Preconditions.checkNotNull(newName, "New branch name cannot be null"); + Preconditions.checkArgument(!name.equals(SnapshotRef.MAIN_BRANCH), "Cannot rename main branch"); + SnapshotRef ref = updatedRefs.get(name); + Preconditions.checkArgument(ref != null, "Branch does not exist: %s", name); + Preconditions.checkArgument(ref.isBranch(), "Ref %s is a tag not a branch", name); + SnapshotRef existing = updatedRefs.put(newName, ref); + Preconditions.checkArgument(existing == null, "Ref %s already exists", newName); + updatedRefs.remove(name, ref); + return this; + } + + public UpdateSnapshotReferencesOperation replaceBranch(String name, long snapshotId) { + Preconditions.checkNotNull(name, "Branch name cannot be null"); + SnapshotRef ref = updatedRefs.get(name); + Preconditions.checkArgument(ref != null, "Branch does not exist: %s", name); + Preconditions.checkArgument(ref.isBranch(), "Ref %s is a tag not a branch", name); + SnapshotRef updatedRef = SnapshotRef.builderFrom(ref, snapshotId).build(); + updatedRefs.put(name, updatedRef); + return this; + } + + public UpdateSnapshotReferencesOperation replaceBranch(String name, String source) { + return replaceBranch(name, source, false); + } + + public UpdateSnapshotReferencesOperation fastForward(String name, String source) { + return replaceBranch(name, source, true); + } + + private UpdateSnapshotReferencesOperation replaceBranch(String name, String source, boolean fastForward) { + Preconditions.checkNotNull(name, "Target branch cannot be null"); + Preconditions.checkNotNull(source, "Source ref cannot be null"); + SnapshotRef sourceRef = updatedRefs.get(source); + SnapshotRef refToUpdate = updatedRefs.get(name); + Preconditions.checkArgument(refToUpdate != null, "Target branch does not exist: %s", name); + Preconditions.checkArgument(sourceRef != null, "Ref does not exist: %s", source); + Preconditions.checkArgument(refToUpdate.isBranch(), "Ref %s is a tag not a branch", name); + + // Nothing to replace + if (sourceRef.snapshotId() == refToUpdate.snapshotId()) { + return this; + } + + SnapshotRef updatedRef = SnapshotRef.builderFrom(refToUpdate, sourceRef.snapshotId()).build(); + + if (fastForward) { + Iterable<Snapshot> ancestors = SnapshotUtil.ancestorsOf(sourceRef.snapshotId(), base::snapshot); + boolean targetIsAncestor = false; + for (Snapshot ancestor : ancestors) { + if (ancestor.snapshotId() == refToUpdate.snapshotId()) { + targetIsAncestor = true; + break; + } Review Comment: I think I'll just add this to SnapshotUtil. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
