findepi commented on code in PR #4534: URL: https://github.com/apache/iceberg/pull/4534#discussion_r851239284
########## core/src/test/java/org/apache/iceberg/io/InMemoryOutputFile.java: ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.io; + +import java.io.ByteArrayOutputStream; +import java.io.IOException; +import java.util.Objects; +import java.util.UUID; + +public class InMemoryOutputFile implements OutputFile { + + private final String location; + + private boolean exists; + private ByteArrayOutputStream contents; + + public InMemoryOutputFile() { + this("memory:" + UUID.randomUUID()); + } + + public InMemoryOutputFile(String location) { + this.location = Objects.requireNonNull(location, "location is null"); + } + + @Override + public PositionOutputStream create() { + if (exists) { + throw new RuntimeException("Already exists"); + } + return createOrOverwrite(); + } + + @Override + public PositionOutputStream createOrOverwrite() { + exists = true; + contents = new ByteArrayOutputStream(); + return new InMemoryPositionOutputStream(contents); + } + + @Override + public String location() { + return location; + } + + @Override + public InputFile toInputFile() { + return new InMemoryInputFile(location(), getContents()); + } + + public byte[] getContents() { + return contents.toByteArray(); + } Review Comment: changed to `toByteArray`, will this be OK? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
