findepi commented on code in PR #4534:
URL: https://github.com/apache/iceberg/pull/4534#discussion_r851241865
##########
core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java:
##########
@@ -235,7 +236,7 @@ void checkRewrittenManifest(ManifestFile manifest, long
expectedSequenceNumber,
}
private InputFile writeManifestList(ManifestFile manifest, int
formatVersion) throws IOException {
- OutputFile manifestList = Files.localOutput(temp.newFile());
+ InMemoryOutputFile manifestList = new InMemoryOutputFile();
Review Comment:
reverted
##########
core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java:
##########
@@ -235,7 +236,7 @@ void checkRewrittenManifest(ManifestFile manifest, long
expectedSequenceNumber,
}
private InputFile writeManifestList(ManifestFile manifest, int
formatVersion) throws IOException {
- OutputFile manifestList = Files.localOutput(temp.newFile());
+ InMemoryOutputFile manifestList = new InMemoryOutputFile();
Review Comment:
~reverted~
##########
core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java:
##########
@@ -235,7 +236,7 @@ void checkRewrittenManifest(ManifestFile manifest, long
expectedSequenceNumber,
}
private InputFile writeManifestList(ManifestFile manifest, int
formatVersion) throws IOException {
- OutputFile manifestList = Files.localOutput(temp.newFile());
+ InMemoryOutputFile manifestList = new InMemoryOutputFile();
Review Comment:
yes, fixed (not reverted)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
