nastra commented on code in PR #4594:
URL: https://github.com/apache/iceberg/pull/4594#discussion_r854160340
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java:
##########
@@ -147,7 +180,7 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
.metadataLocation(newMetadataLocation)
.build();
- LOG.debug("Committing '{}' against '{}': {}", key,
client.getRef().getReference(), newTable);
+ LOG.info("Committing '{}' against '{}', current is '{}': {}", key,
expectedHead, current.getHash(), newTable);
Review Comment:
should this and others stay at `debug`?
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java:
##########
@@ -156,14 +189,15 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
Branch branch = client.getApi().commitMultipleOperations()
.operation(Operation.Put.of(key, newTable, table))
.commitMeta(NessieUtil.catalogOptions(builder,
catalogOptions).build())
- .branch(client.getRef().getAsBranch())
+ .branch(expectedHead)
.commit();
- client.getRef().updateReference(branch);
+ LOG.info("Committed '{}' as '{}', expected commit-id was '{}'", key,
branch, expectedHead.getHash());
Review Comment:
should this say `Committed '{}' against '{}'..` since it's referring to the
branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
