RussellSpitzer commented on code in PR #4594:
URL: https://github.com/apache/iceberg/pull/4594#discussion_r858787765
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -155,7 +155,7 @@ public static String toJson(TableMetadata metadata) {
}
}
- private static void toJson(TableMetadata metadata, JsonGenerator generator)
throws IOException {
Review Comment:
I don't think we want to change accessibility on these methods, why is the
custom JsonGenerator needed in the Nessie code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
