flyrain commented on code in PR #4539:
URL: https://github.com/apache/iceberg/pull/4539#discussion_r854662158
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java:
##########
@@ -146,4 +150,17 @@ public PositionVectorHolder(FieldVector vector, Type type,
NullabilityHolder nul
}
}
+ public static class DeletedVectorHolder extends VectorHolder {
Review Comment:
I guess it's fine, since we've got nested classes `PositionVectorHolder` and
`ConstantVectorHolder` extend `VectorHolder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
