flyrain commented on code in PR #4539:
URL: https://github.com/apache/iceberg/pull/4539#discussion_r853498509
##########
core/src/main/java/org/apache/iceberg/BaseFileScanTask.java:
##########
@@ -47,6 +47,10 @@ public BaseFileScanTask(DataFile file, DeleteFile[] deletes,
String schemaString
this.residuals = residuals;
}
+ public BaseFileScanTask cloneWithoutDeletes() {
+ return new BaseFileScanTask(file, null, schemaString, specString,
residuals);
Review Comment:
Nice suggestion. I don't like to pass `null` either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
