stevenzwu commented on code in PR #4529:
URL: https://github.com/apache/iceberg/pull/4529#discussion_r855330008
##########
core/src/main/java/org/apache/iceberg/BaseAllMetadataTableScan.java:
##########
@@ -40,7 +40,7 @@ abstract class BaseAllMetadataTableScan extends
BaseMetadataTableScan {
protected abstract String tableType();
@Override
- public TableScan appendsBetween(long fromSnapshotId, long toSnapshotId) {
+ public TableScan appendsInRange(Long fromSnapshotId, long toSnapshotId) {
Review Comment:
if the community agrees with PR #4580 , we will abort this PR/approach. In
PR #4580 , we can add more flexible `IncrementalScan` options (not just append)
to support use cases like CDC read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
