yittg commented on PR #4529: URL: https://github.com/apache/iceberg/pull/4529#issuecomment-1094501133
thanks @stevenzwu for providing this change. Personally, i'm not quite sure should we use a such big change to achieve this target. I wonder whether it is a better option to use a special invalid snapshot id value to do the same thing, such as `-1`. Checking this special value can be equivalent with null checking. Or please correct me if it has other effects. Also looking forward others' opinions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
