kbendick commented on PR #4553: URL: https://github.com/apache/iceberg/pull/4553#issuecomment-1105742448
> @kbendick I think we've just merged few iceberg PRs for the old flink 1.14, would you mind to update this PR to include those latest changes to flink 1.15 ? Yeah good catch @openinx. I will keep the two in sync. I have merged the changes from 1.14 into 1.15. Here's the diff between the two ```bash $ diff -qr v1.14/ v1.15/ Files v1.14/build.gradle and v1.15/build.gradle differ Files v1.14/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java and v1.15/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java differ Files v1.14/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSource.java and v1.15/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSource.java differ Files v1.14/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java and v1.15/flink/src/test/java/org/apache/iceberg/flink/TestChangeLogTable.java differ Files v1.14/flink/src/test/java/org/apache/iceberg/flink/TestIcebergConnector.java and v1.15/flink/src/test/java/org/apache/iceberg/flink/TestIcebergConnector.java differ Files v1.14/flink/src/test/java/org/apache/iceberg/flink/source/BoundedTableFactory.java and v1.15/flink/src/test/java/org/apache/iceberg/flink/source/BoundedTableFactory.java differ ``` I checked those files individually and the diff seems correct. I will post the full diff as well before we merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
