openinx commented on PR #4553:
URL: https://github.com/apache/iceberg/pull/4553#issuecomment-1107689942

   ```patch
      @Override
      public ScanRuntimeProvider getScanRuntimeProvider(ScanContext 
runtimeProviderContext) {
        return new DataStreamScanProvider() {
   +
   +      // UPDATED - Needs to be added as support for other signature is 
entirely removed.
   +      // TODO -    This should probably be ported to 1.14 as well to make 
future changes
   +      //           easier to backport.
          @Override
   -      public DataStream<RowData> 
produceDataStream(StreamExecutionEnvironment execEnv) {
   +      public DataStream<RowData> produceDataStream(
   +          ProviderContext providerContext, StreamExecutionEnvironment 
execEnv) {
            return createDataStream(execEnv);
          }
   ```
   
   Let's just open a separate github issue to track this thing,  seems it does 
not make sense to add backport TODO for flink 1.14 in the flink 1.15 source 
code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to