samredai commented on code in PR #4609: URL: https://github.com/apache/iceberg/pull/4609#discussion_r855660002
########## python/tests/expressions/test_expressions_base.py: ########## @@ -15,9 +15,42 @@ # specific language governing permissions and limitations # under the License. +import uuid +from decimal import Decimal +from typing import Any, Union + import pytest from iceberg.expressions import base +from iceberg.types import ( + BinaryType, + BooleanType, + DecimalType, + FloatType, + IntegerType, + StringType, + UUIDType, +) + + +class FooStruct: Review Comment: Yes I didn't subclass it since it's not required but it would be more helpful to include it here. I'll update this 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
