rdblue commented on code in PR #4609:
URL: https://github.com/apache/iceberg/pull/4609#discussion_r855662673
##########
python/src/iceberg/expressions/base.py:
##########
@@ -122,3 +124,37 @@ def __le__(self, other):
def __ge__(self, other):
return self.value >= other.value
+
+
+class Accessor(Generic[T], ABC):
+ """An accessor for a specific position in a container of type T
Review Comment:
It's really close. In Java, we pass in the JVM class for type safety since
this returns the class that you pass in. In Python, there's no need. So you
don't need the `iceberg_type` parameter at all when creating it. Otherwise it
looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
