zhongyujiang commented on code in PR #4535:
URL: https://github.com/apache/iceberg/pull/4535#discussion_r855715474
##########
core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java:
##########
@@ -1388,34 +1395,39 @@ public void testSetIdentifierFieldsFails() {
.setIdentifierFields("locations.key.zip")
.apply());
- AssertHelpers.assertThrows("add a nested field in list should fail",
Review Comment:
Yes it still fails, only now the reason it fails is because the hidden
middle field `element` is optional:
> "Cannot add field x as an identifier field: must not be nested in an
optional field 14: element: optional struct<15: x: required long, 16: y:
required long>"
to contain:
This test is against "list" type, so I added the "required_list.element.x"
test to make sure the Precondtion will fail for the "list" type reason, to
replace it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
