szehon-ho commented on code in PR #4535:
URL: https://github.com/apache/iceberg/pull/4535#discussion_r856426176
##########
core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java:
##########
@@ -1388,34 +1395,39 @@ public void testSetIdentifierFieldsFails() {
.setIdentifierFields("locations.key.zip")
.apply());
- AssertHelpers.assertThrows("add a nested field in list should fail",
Review Comment:
Maybe can add a small code comment, like 'Exploring from root for better
error message for list and map types'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
