rdblue commented on code in PR #4580: URL: https://github.com/apache/iceberg/pull/4580#discussion_r856386926
########## api/src/main/java/org/apache/iceberg/IncrementalScan.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + + +package org.apache.iceberg; + +/** + * API for configuring an incremental table scan + */ +public interface IncrementalScan extends Scan<IncrementalScan> { + + /** + * Optional. if not set, null value will be used for the start snapshot id. + * That would include the oldest ancestor of the {@link IncrementalScan#toSnapshotId(long)}, + * as its parent snapshot id is null which matches the null start snapshot id + * + * @param fromSnapshotId the start snapshot id (exclusive) + * @return an incremental table scan from {@code fromSnapshotId} exclusive + */ + IncrementalScan fromSnapshotId(long fromSnapshotId); + + /** + * Optional. if not set, current table snapshot id is used as the end snapshot id + * + * @param toSnapshotId the end snapshot id (inclusive) + * @return an incremental table scan up to {@code toSnapshotId} inclusive + */ + IncrementalScan toSnapshotId(long toSnapshotId); + + /** + * Only interested in snapshots with append operation + */ + IncrementalScan appendsOnly(); Review Comment: As we talked about, I think it makes sense to remove these two methods since the default for scanning appends is to ignore deletes and overwrites and to read only append snaoshots. ########## api/src/main/java/org/apache/iceberg/IncrementalScan.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + + +package org.apache.iceberg; + +/** + * API for configuring an incremental table scan + */ +public interface IncrementalScan extends Scan<IncrementalScan> { + + /** + * Optional. if not set, null value will be used for the start snapshot id. + * That would include the oldest ancestor of the {@link IncrementalScan#toSnapshotId(long)}, + * as its parent snapshot id is null which matches the null start snapshot id + * + * @param fromSnapshotId the start snapshot id (exclusive) + * @return an incremental table scan from {@code fromSnapshotId} exclusive + */ + IncrementalScan fromSnapshotId(long fromSnapshotId); + + /** + * Optional. if not set, current table snapshot id is used as the end snapshot id + * + * @param toSnapshotId the end snapshot id (inclusive) + * @return an incremental table scan up to {@code toSnapshotId} inclusive + */ + IncrementalScan toSnapshotId(long toSnapshotId); + + /** + * Only interested in snapshots with append operation + */ + IncrementalScan appendsOnly(); Review Comment: As we talked about, I think it makes sense to remove these two methods since the default for scanning appends is to ignore deletes and overwrites and to read only append snapshots. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
