stevenzwu commented on code in PR #4580: URL: https://github.com/apache/iceberg/pull/4580#discussion_r856558969
########## api/src/main/java/org/apache/iceberg/IncrementalAppendScan.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + + +package org.apache.iceberg; + +/** + * API for configuring an incremental table scan for appends only snapshots + */ +public interface IncrementalAppendScan extends Scan<IncrementalAppendScan> { + + /** + * Optional. if from snapshot id (inclusive or exclusive) is not provided, + * the oldest ancestor of the {@link IncrementalAppendScan#toSnapshot(long)} + * will be included as the from snapshot. + * + * @param fromSnapshotId the start snapshot id inclusive + * @return an incremental table scan from {@code fromSnapshotId} inclusive + */ + IncrementalAppendScan fromSnapshotInclusive(long fromSnapshotId); + + /** + * Optional. if from snapshot id (inclusive or exclusive) is not provided, + * the oldest ancestor of the {@link IncrementalAppendScan#toSnapshot(long)} + * will be included as the from snapshot. + * + * @param fromSnapshotId the start snapshot id (exclusive) + * @return an incremental table scan from {@code fromSnapshotId} exclusive + */ + IncrementalAppendScan fromSnapshotExclusive(long fromSnapshotId); + + /** + * Required Review Comment: @rdblue I marked the `toSnapshot` as required. basically, we will not support the use case of old `TableScan#appendsAfter`. The reason is that incremental scan typically need to track the last end position of the incremental scan. Then the last position will be used as the from position in the next (exclusive). Hence, I think the `TableScan#appendsAfter` is probably not a valid use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
