flyrain commented on code in PR #4539:
URL: https://github.com/apache/iceberg/pull/4539#discussion_r856489133
##########
api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java:
##########
@@ -74,4 +74,11 @@ default ExpireSnapshots expireSnapshots(Table table) {
default DeleteReachableFiles deleteReachableFiles(String metadataLocation) {
throw new UnsupportedOperationException(this.getClass().getName() + " does
not implement deleteReachableFiles");
}
+
+ /**
+ * Instantiates an action to generate CDC records.
+ */
+ default Cdc generateCdcRecords(Table table) {
Review Comment:
Combining feedbacks, changed it to `GetChangeSet`. The name
`GenerateChangeSet` is good, but it is way too long. Think about the class name
`BaseGenerateChangeSetSparkActionResult`. I admit the verb `get` is plain
comparing to `generate`. But I think it is fine, a plain name is suitable for a
tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
