flyrain commented on code in PR #4539:
URL: https://github.com/apache/iceberg/pull/4539#discussion_r856589588
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -517,5 +517,32 @@ public void setBatchSize(int batchSize) {
}
}
+ /**
+ * A Dummy Vector Reader which doesn't actually read files, instead it
returns a dummy
+ * VectorHolder which indicates whether the row is deleted.
+ */
+ public static class DeletedVectorReader extends VectorizedArrowReader {
Review Comment:
Vectorized read is significant faster than non-vectorized read, check
benchmark in #3287. We should have it. Non-vectorized read is handled by the
change I made in class `RowDataReader`, `DeleteFilter` and `Deletes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
