flyrain commented on code in PR #4612:
URL: https://github.com/apache/iceberg/pull/4612#discussion_r856565023
##########
core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java:
##########
@@ -251,13 +251,15 @@ private void performRewrite(List<ManifestFile>
currentManifests) {
}
}
- private void validateDeletedManifests(Set<ManifestFile> currentManifests) {
+ private void validateDeletedManifests(Set<ManifestFile> currentManifests,
long currentSnapshotId) {
// directly deleted manifests must be still present in the current snapshot
deletedManifests.stream()
.filter(manifest -> !currentManifests.contains(manifest))
.findAny()
.ifPresent(manifest -> {
- throw new ValidationException("Manifest is missing: %s",
manifest.path());
+ throw new ValidationException("Cannot apply RewriteManifests result,
" +
Review Comment:
Agreed with @RussellSpitzer. The action `RewriteManifests` doesn't need
users to input any snapshot id. A user couldn't do much with the snapshot id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
