kyle-cx commented on code in PR #4612:
URL: https://github.com/apache/iceberg/pull/4612#discussion_r857456460
##########
core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java:
##########
@@ -257,7 +257,10 @@ private void validateDeletedManifests(Set<ManifestFile>
currentManifests) {
.filter(manifest -> !currentManifests.contains(manifest))
.findAny()
.ifPresent(manifest -> {
- throw new ValidationException("Manifest is missing: %s",
manifest.path());
+ throw new ValidationException("Cannot commit RewriteManifests; " +
+ "manifests that existed at the beginning of this rewrite
have already been removed by another " +
+ "operation. Manifest %s, which would be replaced by this
operation, has already been removed.",
+ manifest.path());
Review Comment:
here is the new err msg, looks simple and clear 😄, thx for the suggestion
@rdblue @RussellSpitzer
"Manifest is missing: %s (caused by table changed concurrently)"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
