danielcweeks commented on code in PR #4608:
URL: https://github.com/apache/iceberg/pull/4608#discussion_r856955584
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java:
##########
@@ -111,6 +114,19 @@ public int read(byte[] b, int off, int len) throws
IOException {
return bytesRead;
}
+ @Override
+ public void readFully(long position, byte[] buffer, int offset, int length) {
+ GetObjectRequest.Builder requestBuilder = GetObjectRequest.builder()
+ .bucket(location.bucket())
+ .key(location.key())
+ .range(String.format("bytes=%s-%s", position, position + length));
Review Comment:
Nice catch, this was somewhat silently handled by the way we were handling
the response. Turns out S3 also allows you to specify a range larger than the
object but only returning the up to the end of the object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
