danielcweeks commented on code in PR #4608:
URL: https://github.com/apache/iceberg/pull/4608#discussion_r857027989
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java:
##########
@@ -111,6 +114,19 @@ public int read(byte[] b, int off, int len) throws
IOException {
return bytesRead;
}
+ @Override
+ public void readFully(long position, byte[] buffer, int offset, int length) {
+ GetObjectRequest.Builder requestBuilder = GetObjectRequest.builder()
+ .bucket(location.bucket())
+ .key(location.key())
+ .range(String.format("bytes=%s-%s", position, position + length));
+
+ S3RequestUtil.configureEncryption(awsProperties, requestBuilder);
+
+ ResponseBytes<GetObjectResponse> response =
s3.getObject(requestBuilder.build(), ResponseTransformer.toBytes());
+ System.arraycopy(response.asByteArrayUnsafe(), 0, buffer, offset, length);
Review Comment:
I added checks since we're now not using the System.arraycopy, but I did
take a look at many other implementations of readFully (hadoop, trino, commons)
and none of them perform these checks, so we're being extra cautious here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
