SinghAsDev commented on code in PR #4023:
URL: https://github.com/apache/iceberg/pull/4023#discussion_r858011750
##########
spark/v3.2/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/RowLevelCommandScanRelationPushDown.scala:
##########
@@ -39,16 +43,12 @@ object RowLevelCommandScanRelationPushDown extends
Rule[LogicalPlan] with Predic
val table = relation.table.asRowLevelOperationTable
val scanBuilder = table.newScanBuilder(relation.options)
- val filters = command.condition.toSeq
- val normalizedFilters = DataSourceStrategy.normalizeExprs(filters,
relation.output)
- val (_, normalizedFiltersWithoutSubquery) =
- normalizedFilters.partition(SubqueryExpression.hasSubquery)
-
- val (pushedFilters, remainingFilters) = PushDownUtils.pushFilters(
- scanBuilder, normalizedFiltersWithoutSubquery)
+ val (pushedFilters, remainingFilters) = command.condition match {
+ case Some(cond) => pushFilters(cond, scanBuilder, relation.output)
+ case None => (Nil, Nil)
+ }
- val (scan, output) = PushDownUtils.pruneColumns(
- scanBuilder, relation, relation.output, Seq.empty)
+ val (scan, output) = PushDownUtils.pruneColumns(scanBuilder, relation,
relation.output, Nil)
Review Comment:
Hi @aokolnychyi @szehon-ho any reason for not passing `pushedFilters` here
instead of Nil?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
