RussellSpitzer commented on code in PR #4620:
URL: https://github.com/apache/iceberg/pull/4620#discussion_r858047261
##########
core/src/main/java/org/apache/iceberg/util/StructLikeMap.java:
##########
@@ -104,7 +104,7 @@ public void clear() {
}
@Override
- public Set<StructLike> keySet() {
Review Comment:
I'm not sure we can change these since we'll be breaking an api that is more
or less public .... I need to think on this and the StructLikeSet methods ...
I'm pretty sure we don't want to break the api, but we also don't want to
encourage folks using raw Set's and Maps of StructLike but in this case they
would be safe since we know they came from StructLikeMap and StructLikeSet ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
