[GitHub] [iceberg] felixYyu commented on a diff in pull request #4620: Checkstyle: Add Checkstyle Rule to prevent Map and Set

Mon, 25 Apr 2022 16:28:47 -0700 


felixYyu commented on code in PR #4620:
URL: https://github.com/apache/iceberg/pull/4620#discussion_r858100366


##########
core/src/main/java/org/apache/iceberg/util/StructLikeMap.java:
##########
@@ -104,7 +104,7 @@ public void clear() {
   }
 
   @Override
-  public Set<StructLike> keySet() {

Review Comment:
   Sometimes can use the original, sometimes can't，Then rule `<property 
name="format" value="^Map&lt;StructLike, .*&gt;"/>` may not be able to cover 
the whole.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to