jackye1995 commented on code in PR #4402:
URL: https://github.com/apache/iceberg/pull/4402#discussion_r858175045
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -329,6 +330,36 @@ public class AwsProperties implements Serializable {
public static final String S3_DELETE_ENABLED = "s3.delete-enabled";
public static final boolean S3_DELETE_ENABLED_DEFAULT = true;
+ /**
+ * Used by {@link S3FileIO} to tag objects when writing. To set, we can pass
a catalog property.
+ * <p>
+ * For more details, see
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html
+ * <p>
+ * Example: s3.write.table-uuid-tag-enabled=true
+ */
+ public static final String S3_WRITE_TABLE_UUID_TAG_ENABLED =
"s3.write.table-uuid-tag-enabled";
+ public static final boolean S3_WRITE_TABLE_UUID_TAG_ENABLED_DEFAULT = false;
+
+ /**
+ * Used by {@link S3FileIO} to tag objects when writing. To set, we can pass
a catalog property.
+ * <p>
+ * For more details, see
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html
+ * <p>
+ * Example: s3.write.table-name-tag-enabled=true
+ */
+ public static final String S3_WRITE_TABLE_NAME_TAG_ENABLED =
"s3.write.table-name-tag-enabled";
+ public static final boolean S3_WRITE_TABLE_NAME_TAG_ENABLED_DEFAULT = false;
+
+ /**
+ * Used by {@link S3FileIO} to tag objects when writing. To set, we can pass
a catalog property.
+ * <p>
+ * For more details, see
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html
+ * <p>
+ * Example: s3.write.namespace-tag-enabled=true
+ */
+ public static final String S3_WRITE_NAMESPACE_TAG_ENABLED =
"s3.write.namespace-tag-enabled";
Review Comment:
should this be `namespace-name`?
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -371,11 +414,16 @@ public class AwsProperties implements Serializable {
private final Set<Tag> s3DeleteTags;
private int s3FileIoDeleteThreads;
private boolean isS3DeleteEnabled;
+ private boolean s3WriteTableUuidTagEnabled;
+ private boolean s3WriteTableNameTagEnabled;
+ private boolean s3WriteNamespaceTagEnabled;
private final Map<String, String> s3BucketToAccessPointMapping;
private String glueCatalogId;
private boolean glueCatalogSkipArchive;
private boolean glueLakeFormationEnabled;
+ private String tableName;
+ private String namespace;
Review Comment:
similarly, namespaceName
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
