jackye1995 commented on code in PR #4402:
URL: https://github.com/apache/iceberg/pull/4402#discussion_r858183248
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -110,13 +110,15 @@ public GlueCatalog() {
@Override
public void initialize(String name, Map<String, String> properties) {
AwsClientFactory awsClientFactory;
+ ImmutableMap.Builder<String, String> builder = ImmutableMap.<String,
String>builder().putAll(properties);
Review Comment:
I think we can make this a `tableSpecificPropertiesBuilder`, and at the end
if this builds an empty map it means there is no custom table specific catalog
properties, and we should use the else clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
