kbendick commented on PR #4632:
URL: https://github.com/apache/iceberg/pull/4632#issuecomment-1109394145
I left `AddPartitionSpec` unimplemented because of concerns about processing
incoming JSON that does not have field-id set when parsed, which would be
assigned default field ids (starting at 1000). Want to double check any
potential consequences or realities of that happening.
I'm not even sure that could happen / needs to be accounted for, but after
having that thought I figured it would be better to open the `AddPartitionSpec`
SetDe in a separate PR given that smaller PRs are generally better anyway. I'll
open that one shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
